[move-compiler-v2] clean up a few remaining issues in lambda parser/front-end code #15365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 48m total CI duration on this PR
|
22 tasks
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 22, 2024
brmataptos
changed the title
brmataptos
force-pushed
the
11-21-lambda-compiler-completion
branch
from
3e3563e
to
dac085c
Compare
rahxephon89
reviewed
Nov 23, 2024
| env.error( | ||
| &loc, | ||
| // TODO(LAMBDA) | ||
| "Lambdas expressions with `store` ability currently may only be a simple call to an existing `public` function. This lambda expression requires defining a `public` helper function, which might affect module upgradeability and is not yet supported." |
There was a problem hiding this comment.
This error message looks a little bit confusing for users (e.g what is a helper function and how it may affect upgradeability). Maybe just remove requires defining a public helper function, which might affect module upgradeability` and just saying it is not supported yet?
| env.error( | ||
| &loc, | ||
| &format!( | ||
| "captured variable `{}` must have a value with `copy` ability", // TODO(LAMBDA) |
There was a problem hiding this comment.
Is there a test case for this error?
brmataptos
force-pushed
the
09-27-add_parser_code_for_lambda_types
branch
from
9395a8f
to
cead217
Compare
brmataptos
force-pushed
the
11-21-lambda-compiler-completion
branch
from
dac085c
to
42421fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various fixes:
Constraint::NoFunctionas it's too broad._okversions that compile up to "not implemented" errors.How Has This Been Tested?
Usual tests run, showing unchanged behavior on existing code. Tests under
/lambda/without.lambda.config show proper errors generated if to many functions are used._oktests now show code working up until "not implemented" errors.Key Areas to Review
Most complex stuff is in previous PR, but:
storeandcopyproperties in captured free variables?/lambda/storage/*_ok.movetests look like reasonable code to expect from users?Type of Change
Which Components or Systems Does This Change Impact?
Checklist